[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Make svnperms.py work on Windows

From: Neels Hofmeyr <neels_at_elego.de>
Date: Mon, 3 Jun 2013 13:38:03 +0200

Branko Čibej <brane_at_apache.org>:
> I believe the patch is not correct. It assumes unlimited buffering on
> the stdout and stderr pipes, which is never the case. The way Popen is
> used on the patch can cause the parent and child processes to
> deadlock.
>
> I suggest using Popen.communicate instead.

Agreed. communicate() is what I'd have used, too.

Any other problems with the patch?

It possibly is incompatible with some older version of
python ... but I'd argue that subprocess.Popen is old enough.

~Neels

Received on 2013-06-03 13:39:00 CEST

This is an archived mail posted to the Subversion Dev mailing list.