[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1487954 - /subversion/trunk/build/generator/gen_base.py

From: Bert Huijben <bert_at_qqmail.nl>
Date: Fri, 31 May 2013 11:21:25 +0200

> -----Original Message-----
> From: julianfoad_at_apache.org [mailto:julianfoad_at_apache.org]
> Sent: donderdag 30 mei 2013 20:24
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1487954 -
> /subversion/trunk/build/generator/gen_base.py
>
> Author: julianfoad
> Date: Thu May 30 18:24:24 2013
> New Revision: 1487954
>
> URL: http://svn.apache.org/r1487954
> Log:
> * build/generator/gen_base.py
> (TargetLinked): Remove some redundant and wrong code.
> (_collect_paths): Document what happens if the pattern is not found.
>
> Modified:
> subversion/trunk/build/generator/gen_base.py
>
> Modified: subversion/trunk/build/generator/gen_base.py
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/build/generator/gen_base.
> py?rev=1487954&r1=1487953&r2=1487954&view=diff
> ==========================================================
> ====================
> --- subversion/trunk/build/generator/gen_base.py (original)
> +++ subversion/trunk/build/generator/gen_base.py Thu May 30 18:24:24
> 2013
> @@ -471,10 +471,9 @@ class TargetLinked(Target):
> # the specified install area depends upon this target
> self.gen_obj.graph.add(DT_INSTALL, self.install, self)
>
> - sources = sorted(_collect_paths(self.sources or '*.c' or '*.cpp', self.path))
> + sources = sorted(_collect_paths(self.sources, self.path))

I don't understand the use of the "or '*.cpp'" part as that code appears to dead, but the "or '*.c'" would be used if self.sources would evaluate to false and otherwise the self.sources value.

Maybe we have this same default in another place, but otherwise this would change the behavior when no explicit value is available.

        Bert
Received on 2013-05-31 11:22:28 CEST

This is an archived mail posted to the Subversion Dev mailing list.