[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1485848 - /subversion/trunk/subversion/libsvn_subr/subst.c

From: Konstantin Kolinko <knst.kolinko_at_gmail.com>
Date: Mon, 27 May 2013 22:30:31 +0400

2013/5/24 Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>:
>
> On Fri, May 24, 2013 at 3:10 PM, Stefan Sperling <stsp_at_elego.de> wrote:
>>
>> On Thu, May 23, 2013 at 08:55:32PM -0000, stefan2_at_apache.org wrote:
>> > Author: stefan2
>> > Date: Thu May 23 20:55:32 2013
>> > New Revision: 1485848
>> >
>> > URL: http://svn.apache.org/r1485848
>> > Log:
>> > Double the speed translate_chunk in case that keyword substitution has
>> > not been enabled.
>>
>> I believe this revision is causing crashes in my client built
>> from trunk. The trunk client is also corrupting working copies I use.
>>
>> I'll investigate a bit further, but if my testing shows that this
>> change is reponsible I am going to revert it ASAP to prevent the
>> damage from spreading.
>
>
> If that patch causes problems, feel free to revert it.
> It's not been an important improvement.
>
> I had just stumbled across this function when I was
> investigating why 'svn merge' is so slow.
>
> -- Stefan^2.
>

There is a typo in the commit message:

http://svn.apache.org/viewvc?view=revision&revision=r1485848
says:

[[[
        *** This revision was reverted in r1486046 ***
        *** and re-applied with bugfix in r1486058. ***
]]] ...

It was reverted not in ..046, but in ..044:
http://svn.apache.org/viewvc?view=revision&revision=1486044

Best regards,
Konstantin Kolinko
Received on 2013-05-27 20:31:05 CEST

This is an archived mail posted to the Subversion Dev mailing list.