[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Apache Subversion 1.8.0-rc2 Released

From: Branko Čibej <brane_at_wandisco.com>
Date: Sun, 26 May 2013 20:00:01 +0200

On 26.05.2013 16:41, Barry Scott wrote:
> I see the following warning when compiling on Mac OS X 10.8 with Xcode 4.6.2,
> "Apple clang version 4.0 (tags/Apple/clang-421.0.60) (based on LLVM 3.1svn)".
>
> Would you be willing to change the code to fix the warning?
>
> subversion/libsvn_delta/svndiff.c:791:34: warning: adding 'apr_size_t' (aka 'unsigned long') to a string does not append to the string [-Wstring-plus-int]
> if (memcmp(buffer, "SVN\0" + db->header_bytes, nheader) == 0)
> ~~~~~~~~^~~~~~~~~~~~~~~~~~
> subversion/libsvn_delta/svndiff.c:791:34: note: use array indexing to silence this warning
> if (memcmp(buffer, "SVN\0" + db->header_bytes, nheader) == 0)
> ^
> & [ ]
> subversion/libsvn_delta/svndiff.c:793:39: warning: adding 'apr_size_t' (aka 'unsigned long') to a string does not append to the string [-Wstring-plus-int]
> else if (memcmp(buffer, "SVN\1" + db->header_bytes, nheader) == 0)
> ~~~~~~~~^~~~~~~~~~~~~~~~~~
> subversion/libsvn_delta/svndiff.c:793:39: note: use array indexing to silence this warning
> else if (memcmp(buffer, "SVN\1" + db->header_bytes, nheader) == 0)
> ^
> & [ ]
> 2 warnings generated.

These warnings are clearly silly. I've been actually thinking about
disabling them because they only make a kind of sense for people who're
not used to C.

> Also the following path is needed to make serf 1.2.0 work:

I suggest you report this to the Serf project
(https://code.google.com/p/serf/)

I don't actually bother with Serf all on Mac OS; I just use the one from
homebrew.

-- Brane

-- 
Branko Čibej
Director of Subversion | WANdisco | www.wandisco.com
Received on 2013-05-26 20:00:41 CEST

This is an archived mail posted to the Subversion Dev mailing list.