[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svnadmin upgrade output message i18n issue

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Thu, 23 May 2013 14:28:29 +0100

Dongsheng Song <dongsheng.song_at_gmail.com> writes:

> On Thu, May 23, 2013 at 9:11 PM, Philip Martin
> <philip.martin_at_wandisco.com> wrote:
>> Philip Martin <philip.martin_at_wandisco.com> writes:
>>
>>> So it appears the UTF8 to native conversion is missing from
>>> repos_notify_handler. I think repos_notify_handler should be using
>>> svn_stream_printf_from_utf8 rather than svn_stream_printf.
>>
>> I've fixed trunk to use svn_cmdline_cstring_from_utf8 and proposed it
>> for 1.8.
>>
>
> As GETTEXT(3) man pages said, If and only if
> defined(HAVE_BIND_TEXTDOMAIN_CODESET),
> your commit is OK.
>
> So you should check HAVE_BIND_TEXTDOMAIN_CODESET when you use
> svn_cmdline_cstring_from_utf8.

Are you saying there is a problem with my change? If there is a problem
doesn't already apply to all other uses of svn_cmdline_cstring_from_utf8?

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Received on 2013-05-23 15:29:05 CEST

This is an archived mail posted to the Subversion Dev mailing list.