[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Create/Apply Patch - UTF-16 and binary support

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 22 May 2013 22:28:20 +0200

On Wed, May 22, 2013 at 01:12:00PM -0700, Friedrich Brunzema wrote:
> By the sounds of it, this is not really a burning issue for the
> project - ie not on your roadmap.

That seems to be the case, yes. You never know who is working on
what in an open source project. But there is no evidence of any
development activity related to this. As Julian pointed out, you
could help make it happen!

> If it does not work reliably, is it even worth having the create
> patch/apply patch functionality? [Just putting the question out
> there...]

Well, 'svn patch' is intended as the Subversion equivalent of the
UNIX patch program: http://en.wikipedia.org/wiki/Patch_%28Unix%29
That program cannot handle binary files either. Therefor, such
functionality was never within the scope of 'svn patch'.

The intended use case is easier handling of patch submissions made to
open source projects which use Subversion (such as FreeBSD). Patches
submitted to such projects rarely contain binary files.
I believe 'svn patch' has fulfilled that purpose very well, so I wouldn't
consider it incomplete at all. Your desired feature simply wasn't part
of the goal of the 'svn patch' development effort (there were earlier
'svn patch' development efforts some years ago, which tried to cover
your use case, too, but they weren't completed).

TortoiseSVN 1.6 did include a custom 'patch' feature, but that was
even more limited than the Subversion 1.7 patch feature is now.
Since TortoiseSVN 1.7, TortoiseSVN's patch feature uses the same
code under the hood that 'svn patch' is using, so it provides the
same functionality.
Received on 2013-05-22 22:28:54 CEST

This is an archived mail posted to the Subversion Dev mailing list.