Re: svn commit: r1485007 - /subversion/branches/invoke-diff-cmd-feature/subversion/libsvn_subr/ io.c

Philip Martin wrote on Wed, May 22, 2013 at 10:44:33 +0100:
> Philip Martin <philip.martin_at_wandisco.com> writes:
>
> > My first loop results in a final trailing " " and my second loop results
> > in a leading " ". Perhaps:
> >
> > const char *failed_command = cmd[0];
> > for (i = 1; cmd[i]; ++i)
> > failed_command = apr_psprintf(pool, "%s %s", failed_command, cmd[i]);
>
> Another problem is that you go on to do:
>
> return svn_error_createf(SVN_ERR_EXTERNAL_PROGRAM, NULL,
> _("'%s' was expanded to '%s' and returned %d"),
> external_diff_cmd,
> svn_dirent_local_style(failed_command, pool),
> *pexitcode);
>
> which applies local style to the whole command string not just to paths.
> On Windows that will convert all '/' to '\' and command options on
> Windows can use '/' where Unix would use '-'.

I pointed out this issue already in my branch review.
Received on 2013-05-22 17:45:56 CEST