Re: over-tolerant code in run_file_install?

20 maj 2013 kl. 22.41 skrev Daniel Shahaf:

> Have you checked IRC logs for the day r1142088 was committed on?

Thanks for the reference. As far as I can make out from the
conversation, the change was made in order to handle working copies
whose directory structure had been trashed by the user (intentionally
or by accident). While this may not be a very common case, I certainly
agree that it should work.

The example from the IRC logs was (slightly repaired):

svn ps svn:externals '^/subversion/trunk/notes/ssh-tricks tricks' notes
svn up notes
svn up -r0 notes # tree conflict
rm -rf notes
svn resolved notes
svn up notes # wants cleanup
svn cleanup

and I can confirm that after removing the automatic directory creation
from trunk, that example still fails with an error, so at least it is
not dead code.

> Just for clarify, I assume you want to make run_file_install() use
> svn_io_copy_file() when translation (keyword expansion, etc) is not
> required?
> And when translation is required, you would... retain the current
> "translate to
> tempfile and atomically rename" approach?

Yes and yes.
Received on 2013-05-21 21:51:33 CEST