[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1404856 - in /subversion/trunk/subversion: libsvn_wc/ tests/cmdline/

From: Stefan Sperling <stsp_at_elego.de>
Date: Mon, 20 May 2013 18:37:42 +0200

On Mon, May 20, 2013 at 04:41:38PM +0400, Ivan Zhakov wrote:
> On Fri, Nov 2, 2012 at 5:53 AM, <stsp_at_apache.org> wrote:
> > Author: stsp
> > Date: Fri Nov 2 01:53:23 2012
> > New Revision: 1404856
> >
> > URL: http://svn.apache.org/viewvc?rev=1404856&view=rev

> > + else
> > + return svn_error_createf(SVN_ERR_WC_UPGRADE_REQUIRED, NULL,
> > + _("The working copy at '%s'\nis too old "
> > + "(format %d) to work with client version "
> > + "'%s' (expects format %d). You need to "
> > + "upgrade the working copy first.\n"),
> > + svn_dirent_local_style(wcroot_abspath,
> > + scratch_pool), format, SVN_VERSION,
> > + SVN_WC__VERSION);
> > + }
> Hi Stefan,
>
> What is the reason to add new line character to this particular error
> message? We usually do not use new line in error messages, except for
> logical separation of different part of messages. In this case you
> addded '\n' in middle of sentence.

Just for cosmetic reasons. The path could be very long so it might
be easier to read the error message if it wraps after the path.
But if we don't usually do that, then let's just remove the newline.

I think the newline at the end is a mistake. We usually don't
append a newline to error messages.
Received on 2013-05-20 18:38:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.