[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1461775 - /subversion/trunk/subversion/include/svn_error.h

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Mon, 20 May 2013 17:50:26 +0400

On Mon, May 20, 2013 at 5:49 PM, Ivan Zhakov <ivan_at_visualsvn.com> wrote:
> On Mon, May 20, 2013 at 5:47 PM, Philip Martin
> <philip.martin_at_wandisco.com> wrote:
>> Ivan Zhakov <ivan_at_visualsvn.com> writes:
>>
>>> On Wed, Mar 27, 2013 at 10:39 PM, <cmpilato_at_apache.org> wrote:
>>>> Author: cmpilato
>>>> Date: Wed Mar 27 18:39:56 2013
>>>> New Revision: 1461775
>>>>
>>>> URL: http://svn.apache.org/r1461775
>>>> Log:
>>>> * subversion/include/svn_error.h
>>>> (SVN_ERR_ASSERT): Make this just a wrapper around SVN_ERR_ASSERT_E.
>>>>
>>> It seems to be incorrect change, because expr gets evaluated before
>>> expanding SVN_ERR_ASSERT_E macro and we get just expression value
>>> instead of expression itself. At least on Windows with VC10.
>>
>> Could you give a bit more information. With GCC
>>
>> SVN_ERR_ASSERT(1+1==3);
>>
>> produces
>>
>> ../src/subversion/svn/status-cmd.c:275: (apr_err=SVN_ERR_ASSERTION_FAIL)
>> svn: E235000: In file '../src/subversion/svn/status-cmd.c' line 275: assertion failed (1+1==3)
>> Aborted
>>
>> Are you saying that VC10 produces something different?
>>
> Yes, with VC10 I get "assertion failed (3)"
>
>
Sorry, I meant "assertion failed (0)".

-- 
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com
Received on 2013-05-20 15:51:18 CEST

This is an archived mail posted to the Subversion Dev mailing list.