[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1461775 - /subversion/trunk/subversion/include/svn_error.h

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Mon, 20 May 2013 17:10:33 +0400

On Wed, Mar 27, 2013 at 10:39 PM, <cmpilato_at_apache.org> wrote:
> Author: cmpilato
> Date: Wed Mar 27 18:39:56 2013
> New Revision: 1461775
>
> URL: http://svn.apache.org/r1461775
> Log:
> * subversion/include/svn_error.h
> (SVN_ERR_ASSERT): Make this just a wrapper around SVN_ERR_ASSERT_E.
>
It seems to be incorrect change, because expr gets evaluated before
expanding SVN_ERR_ASSERT_E macro and we get just expression value
instead of expression itself. At least on Windows with VC10.

Any objections to revert this change and backport to 1.8.x?

-- 
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com
Received on 2013-05-20 15:11:27 CEST

This is an archived mail posted to the Subversion Dev mailing list.