Re: svn commit: r1483186 - in /subversion/branches/1.8.x: ./ STATUS subversion/libsvn_client/repos_diff.c subversion/tests/cmdline/diff_tests.py

On 05/20/2013 06:58 AM, Ivan Zhakov wrote:
> On Thu, May 16, 2013 at 8:01 AM, <svn-role_at_apache.org> wrote:
>> Author: svn-role
>> Date: Thu May 16 04:01:25 2013
>> New Revision: 1483186
>>
>> URL: http://svn.apache.org/r1483186
>> Log:
>> Merge the r1482969 group from trunk:
>>
>> * r1482969, r1482970
>> Fix issue #4366 ("client SEGFAULTs diffing a repos rev in which an
>> empty file was added").
>> Justification:
>> SEGFAULTs are consider rude in polite company.
>> Votes:
>> +1: cmpilato, philip, rhuijben
>>
> Issue #4366 also affects merging of empty files: merge of empty files
> add causes crash in Subversion 1.8.0-rc2. It seems to be significant
> reason to re-roll RC and restart soak period.

+1 to a new RC (scheduled by common agreement of the devs -- no need to rush
one out the door).

-1 to restarting the soak period for this.

May I remind us all: a full four-week soak period restart is done to allow
time to exercise the many different codepaths affected by a destabilizing
bugfix. It is *not* done simply because the bug that got fixed is a
high-priority one.

This bug fix is a single boolean toggle that affects one type of operation
(a repository diff which adds empty files) through effectively a single
codepath. The bug is well understood; the fix extremely localized. There's
no need to restart the soak period for this.

We also have a one-week soak period extension as part of our policy:
because this is a critical bugfix, *if* we were currently in our final week
of soak time, we would need to re-roll a new RC with the fix and extend our
soak time by another week.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development