Re: svn commit: r1469520 - /subversion/trunk/subversion/libsvn_fs_fs/tree.c

On 4/19/13 8:04 AM, Philip Martin wrote:
> Daniel Shahaf <danielsh_at_elego.de> writes:
>
>> What would a better fix be?
>
> It's hard to say which is probably why these warnings have not been
> addressed so far. The warning is a 'maybe':
>
> ../src/subversion/libsvn_fs_fs/tree.c:929:27: warning: 'directory' may be used uninitialized in this function [-Wmaybe-uninitialized]
>
> so what will make it go away probably depends on various compiler
> details. A better compiler optimiser might make the warning go away.

Yes, this is a pretty old gcc 4.4 on RedHat 6.3

>> The following is a first sketch, it should resolve the compiler warning
>> but won't solve the actual semantic bug (if there is one) here.
>
> I believe it's a false positive and there is no bug, other than the
> warning, as 'directory' has to be non-NULL if 'here' is non-NULL.

Agreed.
Received on 2013-05-14 08:06:51 CEST