Re: [PATCH] Add contrib/hook-scripts pre-commit for python requiring tabs and svn properties

On Fri, May 10, 2013 at 11:11 AM, Daniel Shahaf <danielsh_at_elego.de> wrote:
> Rice, Kevin (Contractor) wrote on Fri, May 10, 2013 at 15:48:38 +0000:
>> This message, including any attachments, is the property of Sears
> ...
>> without reading the contents. Thank you.
>
> Please nuke these footers when emailing public mailing lists.

Sadly he may not be able to. But more importantly any contribution
that comes with that footer attached becomes hard to accept because it
contradicts any license you may attach to the code. As such I'd say
that you'd probably need to get a Contributor License Agreement on
file in order to contribute this code:
http://www.apache.org/licenses/

However, I agree with Daniel's other point that I don't think this is
sufficiently generic enough to warrant committing to our repo. We do
now have a script intended to make it easy to apply specific rules to
certain files:
http://svn.apache.org/repos/asf/subversion/trunk/tools/hook-scripts/validate-files.py

So in this case I'd probably configure that tool to use some subset of
what is in your script to do the specific tests you want (tab,
eol-style, etc).
Received on 2013-05-10 20:27:27 CEST