[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Thread issues in svnserve

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Thu, 09 May 2013 15:32:31 +0100

Philip Martin <philip.martin_at_wandisco.com> writes:

> It might be better to pass iterpool instead of connection_pool into
> apr_thread_create. The problem with tattr also applies to memory
> allocated by apr_thread_create such as *new. At present *new is not
> accessed after the thread has started but the implementation could
> change. So new patch:

No, that won't work. It's not possible to clear/destroy the pool passed
to apr_thread_create until the thread has started (so that dummy_worker
can access the memory) and there is no guarantee that will have happened
when apr_thread_create returns.

That makes pool handling a bit tricky. We can't use connection_pool
because that goes wrong when the thread completes too quickly, and we
can't use a subpool because that goes wrong when the thread starts too
slowly.

Perhaps we have to look at the httpd code?

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Received on 2013-05-09 16:59:48 CEST

This is an archived mail posted to the Subversion Dev mailing list.