[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Questions about code in svn_client_log5()'s helper func resolve_log_targets()

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Fri, 3 May 2013 23:48:20 +0100 (BST)

I (Julian Foad) wrote:
> I (Julian Foad) wrote:
>>  These functions:
>>
>>    resolve_wc_opt_revs()
>>    resolve_wc_head_revs()
>>    resolve_wc_date_revs()
>>
>> together with the code that calls them, seem to be implementing the basic
>> "convert an svn_opt_revision_t to a revision number" functionality
>> that we already have in other places.  Is that right?  If so, could we
>> avoid re-writing that functionality here?
>>
>> The only thing it appears to be doing that a simple call to, say,
>> svn_client__get_revision_number() doesn't do, is avoid opening a
>> session if one is not needed here.  [...] can't we simply open one
>> before calling this function, and let this function make simple calls to
>> svn_client__get_revision_number()?
>
> The attached patch implements this, shortening the file by 150 lines, and passes
> log_tests.py.

Passed all tests.

Committed revision 1478998.

- Julian
Received on 2013-05-04 00:49:53 CEST

This is an archived mail posted to the Subversion Dev mailing list.