[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1476359 - in /subversion/trunk/subversion/bindings/javahl/src/org: apache/subversion/javahl/types/LogDate.java tigris/subversion/javahl/LogDate.java

From: Mark Phippard <markphip_at_gmail.com>
Date: Mon, 29 Apr 2013 10:54:08 -0400

On Mon, Apr 29, 2013 at 10:44 AM, Philip Martin
<philip.martin_at_wandisco.com> wrote:

>> This would essentially require creating a new object each time the
>> method is needed and that would be a lot. My understanding is that
>> using synchronize is cheaper in this case.
>
> The org.apache bindings only use LogDate in CommitInfo and I would be
> surprised if that was a bottleneck, it simply doesn't get called often
> enough.
>
> The legacy org.tigris bindings use LogDate in LogMessageCallback so I
> suppose it might be a performance issue there, but only in the
> deprecated methods that return an array of log messages. Even then I'd
> expect the real overhead to be building the array to hold all log
> messages in memory.

I think Synchronized is a better solution, but will not object if you
want to make the change. The research you have done have likely given
me a better solution anyway. I was assuming LogDate was still used in
the callback. It turns out that we (Subclipse) are still using it in
the callback even though we use the new org.apache classes. So that
means we can fix this in Subclipse by not using this class anymore.

--
Thanks
Mark Phippard
http://markphip.blogspot.com/
Received on 2013-04-29 16:54:40 CEST

This is an archived mail posted to the Subversion Dev mailing list.