[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Re: svn commit: r1476563 - /subversion/trunk/subversion/svnserve/serve.c

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Sat, 27 Apr 2013 20:38:09 +0300

Julian Foad wrote on Sat, Apr 27, 2013 at 17:51:22 +0100:
> Daniel Shahaf <danielsh_at_elego.de>
> > @@ -197,7 +198,10 @@ svn_ra_svn__skip_leading_garbage(svn_ra_svn_conn_t
> >   * contains two elements, an error will result.
> >   *
> >   * 'B' is similar to 'b', but may be used in the optional tuple
> > specification.
> > - * It returns TRUE, FALSE, or SVN_RA_SVN_UNSPECIFIED_NUMBER.
> > + * It returns TRUE, FALSE, or SVN_RA_SVN_UNSPECIFIED_NUMBER.  This format
> > + * code is deprecated; new code should use '3' instead.
> > + *
> > + * '3' is like 'B', mutatis mutandis.
>
> Inaccurate. Try:
>
>   * '3' is similar to 'b', but may be used in the optional tuple specification.
>   * It returns svn_tristate_true, svn_tristate_false or svn_tristate_unknown.
>   *
>   * 'B' is deprecated.  It is similar to '3', but it returns
>   * TRUE, FALSE, or SVN_RA_SVN_UNSPECIFIED_NUMBER.
>
> Also the final sentence should be changed:
>
>   * will be set to @c NULL.  'b' may not appear inside an optional
> - * tuple specification; use 'B' instead.
> + * tuple specification;  use '3' instead.
>

Good suggestions, incorporated.

Committed in r1476641.

Thanks,

Daniel
Received on 2013-04-27 19:38:45 CEST

This is an archived mail posted to the Subversion Dev mailing list.