[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1476366 - /subversion/trunk/subversion/svn/props.c

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Sat, 27 Apr 2013 13:46:29 +0300

julianfoad_at_apache.org wrote on Fri, Apr 26, 2013 at 19:59:09 -0000:
> Author: julianfoad
> Date: Fri Apr 26 19:59:09 2013
> New Revision: 1476366
>
> URL: http://svn.apache.org/r1476366
> Log:
> * subversion/svn/props.c
> (svn_cl__check_svn_prop_name): Eliminate an unsafe printf format string
> by using svn_error_create() instead of svn_error_createf().
>

unsafe printf string == heap underflow == potential segfault == backport candidate?

Daniel

> Modified:
> subversion/trunk/subversion/svn/props.c
>
> Modified: subversion/trunk/subversion/svn/props.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/props.c?rev=1476366&r1=1476365&r2=1476366&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/svn/props.c (original)
> +++ subversion/trunk/subversion/svn/props.c Fri Apr 26 19:59:09 2013
> @@ -321,7 +321,7 @@ svn_cl__check_svn_prop_name(const char *
> {
> case 0:
> /* The best alternative isn't good enough */
> - return svn_error_createf(
> + return svn_error_create(
> SVN_ERR_CLIENT_PROPERTY_NAME, NULL,
> wrong_prop_error_message(prop_use, propname, scratch_pool));
>
>
>
Received on 2013-04-27 12:47:19 CEST

This is an archived mail posted to the Subversion Dev mailing list.