[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix non-ASCII cmdline options in non-UTF-8 locales

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Fri, 26 Apr 2013 05:15:44 +0300

Julian Foad wrote on Fri, Apr 26, 2013 at 00:32:32 +0100:
> Some other arguments, including '--native-eol', are not converted
> before testing for valid values, and the valid values are always
> ASCII. This is OK, if we assume an ASCII subset. That's probably
> safe, as [1] indicates that all common encodings except EBCDIC have an
> ASCII subset. On the other hand, it does no harm to convert first,
> and doing so is more consistent with how we handle other options.

If we decide not to convert, a comment documenting the decision might be
useful.
Received on 2013-04-26 04:16:28 CEST

This is an archived mail posted to the Subversion Dev mailing list.