[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1471717 - /subversion/trunk/subversion/svnadmin/svnadmin.c

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Thu, 25 Apr 2013 14:04:41 +0300

Ivan Zhakov wrote on Thu, Apr 25, 2013 at 13:29:05 +0400:
> On Thu, Apr 25, 2013 at 3:14 AM, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> > On IRC you also made a point about the "Config files" output (prints the
> > path to DB_CONFIG or to fsfs.conf). Do you think it should be removed
> > from 'svnadmin info'? From svn_fs.h (svn_fs_info_config_files)?
> My personal opinion that "Config files" are not useful in 'svnadmin
> info' and should be removed from output and API. In this case
> 'svnadmin info' output would be more regular.

Not sure what you mean by 'more regular'. We also don't print sharding
information for BDB filesystems, if that's what you mean...

I'd still like to hear what others think about possibly printing the
path to fsfs.conf / DB_CONFIG in the output, whether it should be kept
or axed or modified.

> Another problem is long repository path:
> [[[
> % $svnadmin create C:\ProgramData\Subversion\SuperRepo && $svnadmin
> info C:\ProgramData\Subversion\SuperRepo
> Path: C:\ProgramData\Subversion\SuperRepo
> Repository Format: 5
> Filesystem Format: 6
> Compatible With Version: 1.8.0
> Repository Capabilities: mergeinfo
> Filesystem Type: fsfs
> FSFS Sharded: yes
> FSFS Shard Size: 4
> FSFS Packed: yes
> Config File: C:\ProgramData\Subversion\SuperRepo\db\fsfs.conf
> ]]]
> 'Config File' is hard to scan visually IMHO.

Don't pass an abspath to svnadmin and you won't get an abspath in the
"Config File" field.
Received on 2013-04-25 13:05:21 CEST

This is an archived mail posted to the Subversion Dev mailing list.