[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Issue #4358 - Svn WC 1.8 upgrade from 1.7 - wrong schema

From: Bert Huijben <bert_at_qqmail.nl>
Date: Mon, 22 Apr 2013 20:18:02 +0200

> -----Original Message-----
> From: Julian Foad [mailto:julianfoad_at_btopenworld.com]
> Sent: maandag 22 april 2013 18:51
> To: Subversion Development
> Subject: Issue #4358 - Svn WC 1.8 upgrade from 1.7 - wrong schema
>
> I noticed that a fresh 1.8.x (pre-release) WC has a different schema from
a
> WC created by 1.7.8 and upgraded by 1.8.x.  (I haven't tried different
1.7.x
> versions.)  The differences are:
>
>
> --- schema-1.7.8-upgraded-to-1.8-dev
> +++ schema-1.8-dev
>
> -   file_external  TEXT,
> +   file_external  INTEGER,

This doesn't matter for our use of Sqlite. We only use NULL vs set, but
integer documents what we now store in file_external.

Sqlite doesn't implement an ALTER table statement that can update this, so I
don't think we should try to change this for 1.8.

>
>
> -CREATE INDEX I_ACTUAL_PARENT ON ACTUAL_NODE (
> -    wc_id, parent_relpath);
> +CREATE UNIQUE INDEX I_ACTUAL_PARENT ON ACTUAL_NODE (
> +    wc_id, parent_relpath, local_relpath);
>
> -CREATE INDEX I_NODES_PARENT ON NODES (
> -    wc_id, parent_relpath, op_depth);
> +CREATE UNIQUE INDEX I_NODES_PARENT ON NODES (
> +    wc_id, parent_relpath, local_relpath, op_depth);

I'll look into these tomorrow, but the performance difference is not that
large. And as the names are 100% identical they can never cause problems
upgrading to future versions. (And SQL guarantees that this can't affect our
queries in any other way than performance)

        Bert
Received on 2013-04-22 20:19:04 CEST

This is an archived mail posted to the Subversion Dev mailing list.