Re: log --search test failures on trunk and 1.8.x

On Sun, Apr 21, 2013 at 07:11:14PM +0400, Ivan Zhakov wrote:
> So I propose the following plan:
> 1. Make 'log --search" case-sensitive in trunk and 1.8.x.
> 2. Merge utf8proc stuff to trunk
> 3. Implement svn_utf__casefold() using utf8proc
> 4. Implement 'log --isearch' using

No --isearch please. It did exist on trunk but we made --search
case-insensitive in r1388530 to avoid having too many options.

Has anyone tried my APR patch on windows yet? I'd be interested to
know whether or not that helps... if you are running Windows and
care about this issue, please let me know if my APR patch helps so
that I can prepare a fix for APR and SVN 1.8.x. I think we can do
better than making --search case-sensitive just because of a bug in APR.

I don't see why we couldn't ship a private and fixed version of
apr_fnmatch() for use by log --search in 1.8.x, to avoid undefined
behaviour within tolower() via apr_fnmatch() without requiring future
APR versions. Would this not be a good way of fixing this?
Received on 2013-04-22 00:08:27 CEST