[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Potential bug in follow_moved_to()

From: Ben Reser <ben_at_reser.org>
Date: Thu, 18 Apr 2013 16:12:33 -0700

On Thu, Apr 18, 2013 at 4:06 PM, Ben Reser <ben_at_reser.org> wrote:
> In subversion/libsvn_wc/wc_db.c the function follow_moved_to() has an
> int working_op_depth.
>
> It gets initialized by running a db query and if there is a row result
> it's set with:
> working_op_depth = svn_sqlite__column_text(stmt, 1, result_pool);
>
> Later on it's used in a couple of places including some loop control.
>
> However, there seems to be no error handling if there is no resulting row.
>
> I'd fix it myself but I'm not familiar enough with the code to know
> what sort of error should be thrown here.

Nevermind, I missed the code on line 12020 that handles this condition.
Received on 2013-04-19 01:13:07 CEST

This is an archived mail posted to the Subversion Dev mailing list.