[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: crash when diffing, using 1.8.x

From: Ben Reser <ben_at_reser.org>
Date: Sun, 14 Apr 2013 11:07:50 -0700

Committed in r1467807.

On Sun, Apr 14, 2013 at 9:47 AM, Stefan Küng <tortoisesvn_at_gmail.com> wrote:
> Hi,
>
> Easy to reproduce:
>
> $ cd workingcopy
> $ svn diff . --internal-diff
>
> If you pass --internal-diff, then svn_config_set() is called with NULL as
> the value to remove it.
> However when doing the diff, config.c, make_string_from_option later uses
> that NULL value:
>
> if (strchr(opt->value, '%'))
>
> opt-value here is NULL, and therefore strchr crashes.
>
> I suggest changing that line to
> if (opt->value && strchr(opt->value, '%'))
>
> Stefan
>
> --
> ___
> oo // \\ "De Chelonian Mobile"
> (_,\/ \_/ \ TortoiseSVN
> \ \_/_\_/> The coolest interface to (Sub)version control
> /_/ \_\ http://tortoisesvn.net
Received on 2013-04-14 20:08:24 CEST

This is an archived mail posted to the Subversion Dev mailing list.