[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1464993 - in /subversion/trunk/subversion: include/svn_fs.h include/svn_repos.h libsvn_fs/fs-loader.c libsvn_repos/repos.c

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Sat, 6 Apr 2013 21:35:26 +0300

Daniel Shahaf wrote on Fri, Apr 05, 2013 at 18:47:26 +0300:
> THanks for the review, commnts inline:
>
> Ivan Zhakov wrote on Fri, Apr 05, 2013 at 19:40:16 +0400:
> > On Fri, Apr 5, 2013 at 6:47 PM, <danielsh_at_apache.org> wrote:
> > > + /** Filesystem backend (#fs_type) -specific information.
> > > + * @see SVN_FS_FSFS_INFO_* */
> > > + apr_hash_t *fsap_info;
> > > +
> > What is the values of this hash table? Always strings? What about
> > integers or booleans?
> >
>
> Each SVN_FS_FSFS_INFO_* macro will define its value's type. I suppose
> we can encourage the values to be, say, C strings in most cases.
>
> > > + /** List of user-serviceable config files.
> > > + * Elements are dirents (as const char *). */
> > > + apr_array_header_t *config_files;
> > I don't see real use why config_files information can be useful in
> > svnadmin info command. So I suggest to remove it until we need it.
> >
>
> ACK. I assumed this would be useful. What do others think?
> (this would contain ["DB_CONFIG"] or ["fsfs.conf"], currently.)

FWIW, I've already written the code, and I didn't have any better place
to save it in so I went ahead and committed it. If we end up deciding
it's not a good API to have I'll just 'svn undo' it (err, I mean, revert
it).
Received on 2013-04-06 20:36:19 CEST

This is an archived mail posted to the Subversion Dev mailing list.