[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1465112 - /subversion/trunk/subversion/libsvn_subr/simple_providers.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Fri, 5 Apr 2013 23:03:37 +0200

> -----Original Message-----
> From: cmpilato_at_apache.org [mailto:cmpilato_at_apache.org]
> Sent: vrijdag 5 april 2013 22:14
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1465112 -
> /subversion/trunk/subversion/libsvn_subr/simple_providers.c
>
> Author: cmpilato
> Date: Fri Apr 5 20:14:01 2013
> New Revision: 1465112
>
> URL: http://svn.apache.org/r1465112
> Log:
> Allow credentials cleanup even when the 'no-auth-cache' option is set.
> If someone doesn't want to fiddle with their auth cache, they
> shouldn't call this function. Also, don't send credentials through
> the cleanup callback which are not ultimately managed by Subversion
> (because they live in a third-party security provider).
>
> * subversion/libsvn_subr/simple_providers.c
> (svn_auth__simple_cleanup_walk): Allow cleanup even when
> 'no-auth-cache' flag is set. Don't allow cleanup of credentials
> which are housed in third-party providers. Finally, stop passing
> a cred kind value as a provider. Strictly speaking, we don't even
> have a name for our proprietary Subversion caching provider, but
> there's at least some degree of precedent for using the "simple"
> password type string, so run with that for now.

This fails the build with

[[[
..\..\..\subversion\tests\libsvn_subr\auth-test.c:308: (apr_err=200006)
svn_tests: E200006: assertion '! credentials' failed at ..\..\..\subversion\tests\libsvn_subr\auth-test.c:308
FAIL: auth-test.exe 2: test svn_auth_clear()
]]]

On all buildbots,

        Bert
Received on 2013-04-05 23:04:17 CEST

This is an archived mail posted to the Subversion Dev mailing list.