[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1464769 - in /subversion/trunk/subversion/libsvn_client: revert.c switch.c update.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Fri, 05 Apr 2013 11:36:54 +0100

julianfoad_at_apache.org writes:

> Author: julianfoad
> Date: Thu Apr 4 21:14:06 2013
> New Revision: 1464769
> URL: http://svn.apache.org/r1464769
> Log:
> Sleep for timestamps even if using commit times as timestamps.
> Before r1463721, 'revert' did not sleep if using commit times, while
> 'checkout' and 'update' and 'switch' would sleep regardless. r1463721 made
> all of those operations omit the sleep if using commit times, but Philip and
> Ben discussed and pointed out that the commit time could still be within the
> timestamp resolution and so that could be unsafe. Therefore we will sleep
> anyway, in all of those operations, to be safe.
> (The commit time could also be *after* the local time because of clock skew,
> which adds the possibility that the sleep takes us *into* an unsafe time
> period, but we're not trying to address that problem here.)

I don't really understand this log and it mentions my name. I still
think if the user has use-commit-times=yes then we should not sleep. In
that mode we are setting the timestamps to completely arbitrary times,
times that can be changed by changing svn:date. How does sleeping make
anything more reliable?

Certified & Supported Apache Subversion Downloads:
Received on 2013-04-05 12:37:40 CEST

This is an archived mail posted to the Subversion Dev mailing list.