[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Horrible error message on refused diff

From: Bert Huijben <bert_at_qqmail.nl>
Date: Thu, 4 Apr 2013 12:19:32 +0200

> -----Original Message-----
> From: Ben Reser [mailto:ben_at_reser.org]
> Sent: donderdag 4 april 2013 06:09
> To: Subversion Development
> Subject: Horrible error message on refused diff
>
> Was trying to look at a commit that was in another part of the ASF
> repo today. Wanted to see the log and the diff. So hey I just do the
> following in my command line (trunk SVN in this case) and I get:
>
> [[[
> $ svn-trunk log -c r1464241 --diff http://svn.apache.org/repos/asf
> ------------------------------------------------------------------------
> r1464241 | trawick | 2013-04-03 17:22:52 -0700 (Wed, 03 Apr 2013) | 8
lines
>
> mod_dav: Improve error handling in dav_method_put(), add new
> dav_join_error() function.
>
> PR: 54145
>
> Submitted by: Ben Reser <ben reser.org>
> Reviewed by: trawick
>
>
> ../../share/wcs/svn-trunk/subversion/svn/log-cmd.c:868: (apr_err=175009)
> ../../share/wcs/svn-trunk/subversion/libsvn_client/log.c:630:
> (apr_err=175009)
> ../../share/wcs/svn-trunk/subversion/libsvn_ra_serf/log.c:601:
> (apr_err=175009)
> ../../share/wcs/svn-trunk/subversion/libsvn_ra_serf/util.c:819:
> (apr_err=175009)
> ../../share/wcs/svn-trunk/subversion/libsvn_ra_serf/util.c:776:
> (apr_err=175009)
> ../../share/wcs/svn-trunk/subversion/libsvn_ra_serf/util.c:2093:
> (apr_err=175009)
> ../../share/wcs/svn-trunk/subversion/libsvn_ra_serf/util.c:2074:
> (apr_err=175009)
> ../../share/wcs/svn-trunk/subversion/libsvn_ra_serf/util.c:2556:
> (apr_err=175009)
> ../../share/wcs/svn-trunk/subversion/libsvn_ra_serf/util.c:2464:
> (apr_err=175009)
> ../../share/wcs/svn-trunk/subversion/libsvn_ra_serf/xml.c:771:
> (apr_err=175009)
> ../../share/wcs/svn-trunk/subversion/libsvn_ra_serf/log.c:306:
> (apr_err=175009)
> ../../share/wcs/svn-trunk/subversion/svn/log-cmd.c:469: (apr_err=175009)
> ../../share/wcs/svn-trunk/subversion/svn/log-cmd.c:143: (apr_err=175009)
> ../../share/wcs/svn-trunk/subversion/libsvn_client/diff.c:2071:
> (apr_err=175009)
> ../../share/wcs/svn-trunk/subversion/libsvn_client/diff.c:1785:
> (apr_err=175009)
> ../../share/wcs/svn-trunk/subversion/libsvn_ra_serf/update.c:2888:
> (apr_err=175009)
> ../../share/wcs/svn-trunk/subversion/libsvn_ra_serf/util.c:2093:
> (apr_err=175009)
> ../../share/wcs/svn-trunk/subversion/libsvn_ra_serf/util.c:2074:
> (apr_err=175009)
> ../../share/wcs/svn-trunk/subversion/libsvn_ra_serf/util.c:1694:
> (apr_err=175009)
> ../../share/wcs/svn-trunk/subversion/libsvn_ra_serf/util.c:1402:
> (apr_err=175009)
> svn: E175009: XML parsing failed: (403 Forbidden)

The server-side error is generated by mod_dontdothat, but I agree that the
'XML parsing failed' part shouldn't be shown in normal cases.
(The stacktrace above the error is maintainer only)

I added a regression test reproducing the specific error in r1464416, which
should make the error path easier to debug in serf.
(It appears there should be a better error message available, which is
currently ignored on the client)

        Bert
Received on 2013-04-04 12:20:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.