Re: svn commit: r1464122 - in /subversion/trunk/subversion/libsvn_repos: commit.c fs-wrap.c hooks.c load-fs-vtable.c repos.h

On Wed, Apr 03, 2013 at 03:49:03PM -0400, C. Michael Pilato wrote:
> On 04/03/2013 03:14 PM, Bert Huijben wrote:
> > I can???t really see it using just the context in this patch, but doesn???t this
> > undo the don???t parse if no hook script exists patch from Ivan?
>
> Yes, it does. Bummer. I missed that.
>
> Not sure how to proceed then, unless we just revert my change and return to
> parsing these files over and over again. How many times will the hook-env
> file get parsed for the target repository of an svnsync operation?
>
> (start-commit + pre-commit + post-commit +
> ((pre-revprop-change + post-revprop-change) x NUM_PROPS)) x NUM_REVS ?

May I reiterate my suggestion to cache the filesize + mtime of the hooks-env
file and only open() it and parse it if those have changed since the last time
we looked at it? (If they haven't changed, we'd use a hash cached in the
repos object.)

That means we will stat the file often but parse it rarely.
Received on 2013-04-03 22:14:30 CEST