Re: 1.8 new public API review (mostly) complete.

On Tue, Apr 2, 2013 at 6:01 AM, Julian Foad <julianfoad_at_btopenworld.com> wrote:
> Should be "an absolute dirent", since dirents can also be relative and I understood that these functions require them to be absolute.

No requirement that the dirent be absolute. We use absolute dirents
in our servers out of security paranoia but the function doesn't
enforce it. In fact svnauthz uses this since you can pass it relative
paths and it doesn't bother to convert them to absolute paths before
calling svn_repos_authz_read2().

> I did a quick read-through review and found a little error leak in svnserve/serve.c. (I'm unfamiliar with the code so can only look for low-level issues.)
>> + if (groupsdb_path && !err)
>> + canonicalize_access_file(&groupsdb_path, server, repos_root, pool);
>
> Missing "err = " on this line.

Oops, thanks for the review. Fixed in r1463793.
Received on 2013-04-03 01:44:28 CEST