Re: 1.8 new public API review (mostly) complete.

On Mon, Apr 1, 2013 at 10:34 AM, Ben Reser <ben_at_reser.org> wrote:
> On Mon, Apr 1, 2013 at 9:27 AM, Julian Foad <julianfoad_at_btopenworld.com> wrote:
>> First we need to clarify what "@a path (a file,)" means. From the discussion below I gather "a file" means an absolute local filesystem path, so let's say so.
>
> Yes absolute OS filesystem path. I prefer saying OS filesystem path
> because it may not actually be local if it's some sort of network
> mount, so I think local clouds the issue. I'm not sure what we've
> been using in our API docs, but if we've been using local that way
> then that's fine.

I changed it to say "a dirent" which fits with our naming scheme for
types of paths.

>> That could work, but it is *much* nicer in my opinion to get rid of the relative-URL option and get rid of the 'repos_root' argument (which was Ben's original suggestion IIUC). It's simple, cheap, and easy.
>
> Yes, that was my original suggestion. I'll go ahead and do that.

Done along with the doc change mentioned above in r1463374.
Received on 2013-04-02 06:01:50 CEST