Re: svn commit: r1462054 - in /subversion/branches/verify-at-commit/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_fs/fs-loader.h

On Thu, Mar 28, 2013 at 11:36:50AM -0000, danielsh_at_apache.org wrote:
> Author: danielsh
> Date: Thu Mar 28 11:36:50 2013
> New Revision: 1462054
>
> URL: http://svn.apache.org/r1462054
> Log:
> On the verify-at-commit branch, add a backend-independent implementation:
> a db/fs.conf file.

As I said on IRC, I think it makes more sense to implement this
on a per-filesystem basis. The generic fs wrapper can only verify
the transaction, but there is no guarantee that this really represents
the data written during commit. E.g. in FSFS we could check the rev
and revprop files before updating 'current', which leaves less room
for error between verification and commit. For BDB -- dunno.

If we decide that verifying transactions before commit is a good
thing, I'd much rather see a new 'svnlook verify' command that can
be run from the pre-commit hook, instead of this implementation.

Does that make sense?
Received on 2013-03-28 12:50:26 CET