[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] #include limts.h for ULONG_MAX

From: Joe Swatosh <joe.swatosh_at_gmail.com>
Date: Wed, 27 Mar 2013 20:56:35 -0700

On Wed, Mar 27, 2013 at 6:58 PM, Joe Swatosh <joe.swatosh_at_gmail.com> wrote:
> On Wed, Mar 27, 2013 at 4:03 AM, Stefan Sperling <stsp_at_elego.de> wrote:
>> On Wed, Mar 27, 2013 at 10:25:16AM +0000, Philip Martin wrote:
>>> Joe Swatosh <joe.swatosh_at_gmail.com> writes:
>>>
>>> > Okay, thanks for giving me hints on this. As a matter of fact, my apr
>>> > does NOT have a section like this. It is just doing a straight up copy
>>> > of apr.hw. I've downloaded a few different versions of apr and none of
>>> > them have a block like that in apr.hw. Heading over to the apr list
>>> > now to ask for more help....
>>> >
>>> > Again thanks for pointing out to me why it's working for everyone else.
>>>
>>> It may still be a bug in Subversion. We are using ULONG_MAX in
>>> svn_types.h:
>>>
>>> #define SVN_LINENUM_MAX_VALUE ULONG_MAX
>>>
>>> and ULONG_MAX isn't an APR constant. Perhaps Subversion should be
>>> including limits.h explicitly rather than relying on apr.h to pull it
>>> in?
>>
>> Joe,
>>
>> we discussed this further on IRC here:
>> http://colabti.org/irclogger/irclogger_log/svn-dev?date=2013-03-27#l140
>>
>> +1 on your original patch that adds #include <limits.h> to svn_types.h.
>> Please commit it. Thanks!
>
>

BTW, the answer on the apr list was that the inclusion of <limits.h>
was a "side effect" of the implementation of apr on Unix. So this
seems like the right approach....

--
Joe
Received on 2013-03-28 04:57:15 CET

This is an archived mail posted to the Subversion Dev mailing list.