Re: Filenames with trailing newlines wreak havoc

On Wed, Mar 27, 2013 at 10:01:01AM -0700, Ben Reser wrote:
> > Something like the proposal above, to reject LF only at the FS (or FSFS)
> > layer, and all control characters in libsvn_repos, sounds good to me.
> > We should write unit tests to ensure that the FS layer works
> > properly with all other control characters.
>
> I really don't like this proposal. I think a major reason why we're
> in this situation is that we've been inconsistent.

FWIW, I agree that there will be few, if any, practical implications
from adding stricter verification to the FS layer. But I don't really
care which layer does the validation, as long as it is being done
somewhere on the server-side.

So I've implemented this proposal in r1461701 and r1461760, and now
we have code for both approaches in our repository history.
I'll let everyone else discuss which approach is better and then
do whatever needs to be done to get a fix shipped.
Received on 2013-03-27 19:19:53 CET