[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

svn_wc_add_from_disk2 doesn't support skip_some_checks

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Tue, 26 Mar 2013 22:15:22 +0000

Daniel Shahaf <d.s_at_daniel.shahaf.name> writes:

> Marshall Schor wrote on Tue, Mar 26, 2013 at 15:29:43 -0400:
>> I recently created some new binary files. I happened to pick a name for these
>> that ended in ".data", thinking that would remind me and others in the future
>> that this was just data.
>>
>
> Thanks, r1461328.

"svn add" won't add files that set both a binary svn:mime-type and an
svn:eol-style. The low level function that checks the properties has a
skip_some_checks flag to allow the combination which is how both
properties can be set using "svn propset --force". "svn add" also has
--force but it doesn't work to add the file with both properties because
svn_wc_add_from_disk2 doesn't support skip_some_checks. This is
explicitly mentioned in the docs:

 * Check and canonicalize the properties in the same way as
 * svn_wc_prop_set4(). Return an error and don't add the node if the
 * properties are not valid on this node. Unlike svn_wc_prop_set4()
 * there is no option to skip some of the checks and canonicalizations.

but without any rationale. This function is new in 1.8 so we could
easily change it. Does anyone remember why the function behaves this
way?

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Received on 2013-03-26 23:16:08 CET

This is an archived mail posted to the Subversion Dev mailing list.