[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Filenames with trailing newlines wreak havoc

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Tue, 26 Mar 2013 16:29:07 -0400

On 03/26/2013 04:16 PM, Daniel Shahaf wrote:
> Ivan Zhakov wrote on Wed, Mar 27, 2013 at 00:13:12 +0400:
>> On Tue, Mar 26, 2013 at 11:48 PM, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
>>> Ivan Zhakov wrote on Tue, Mar 26, 2013 at 21:57:42 +0400:
>>>> Can we just extend [FS validation] to prohibit all characters with ascii code < 31 ?
>>>
>>> We can but that would break an API promise. (A promise that we might be
>>> fine with breaking.)
>> I don't see API breakage here:
>> 1. We already prohibited some FS paths (with . or ..)
>> 2. Only new paths will be affected: users still can access already
>> created files/folders in repository.
>
> svn_fs.h:1202
> (I thought I'd given that pointer upthread)

Yup. That's precisely the comment I was thinking of, too.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2013-03-26 21:29:42 CET

This is an archived mail posted to the Subversion Dev mailing list.