Re: Filenames with trailing newlines wreak havoc

On Tue, Mar 26, 2013 at 06:10:35PM +0200, Daniel Shahaf wrote:
> I'd call it a DoS if you can commit such a file and can't later 'svn rm
> URL' it.

You cannot 'svnsync' the repository anymore, even if you rm the URL.
So you can DoS a master/slave setup and force the slave to be
out-of-date with no way to catch up until the revision is obliterated
or repaired.

> Or we could forbid newlines in pathnames. The only problem with that is
> that the 1.0 API promised they would work... but if no one uses that,
> I'd be fine with calling it an erratum and disallowing it henceforth.

I think we should disallow it. There are too many unforeseen side effects.
I'm not even sure if I've already seen all failure modes that can result
from this.
Received on 2013-03-26 17:27:40 CET