RE: [PATCH] #include limts.h for ULONG_MAX

Isn't there an apr variant of this macro we can/should use?

Bert From: Joe Swatosh
Sent: 25-3-2013 01:01
To: SVN Dev
Subject: [PATCH] #include limts.h for ULONG_MAX
While I found this issue using my very old compiler, it seems reasonable since
that is where ULONG_MAX has been defined for a long time. (Since clearly no one
else is running into this).

[[[
For those of us with somewhat deficient compilers that don't provide ULONG_MAX
unless <limits.h> is explicitly included.

 * subversion/include/svn_types.h
   (includes): Add include of limits.h
]]]

Index: subversion/include/svn_types.h
===================================================================
--- subversion/include/svn_types.h (revision 1460195)
+++ subversion/include/svn_types.h (working copy)
@@ -29,6 +29,7 @@

 /* ### this should go away, but it causes too much breakage right now */
 #include <stdlib.h>
+#include <limits.h> /* for ULONG_MAX */

 #include <apr.h> /* for apr_size_t, apr_int64_t, ... */
 #include <apr_errno.h> /* for apr_status_t */
Received on 2013-03-25 08:34:01 CET