> Julian Foad wrote on Fri, Mar 22, 2013 at 15:48:56 +0000:
> > If I'm runnning a 1.7 svnadmin and I request "--compatible-version=1.9.0", then certainly 1.7 *can* create a repository that's compatible with v1.9, but I think the meaning should be: create a repo using the 1.9 format, that is compatible with 1.9 and *later*.
> >
> > It would be confusing if the admin tries to create a 1.9-format repo, but is accidentally running the 1.7 svnadmin, and if the 1.7 svnadmin silently goes ahead with creating a 1.7-format repo.
[Daniel Shahaf]
> I was assuming for this use-case you would run 'svnadmin --version
> --quiet' and then compare the result to "1.9.0". (We can introduce a
> subcommand for that: svnadmin version --is-at-least=1.9.0, which
> either prints "yes" and exits 0 or prints "no" and exits 1.)
I agree with Julian. If you're running svnadmin 1.7 and you ask to
create a 1.9 format repository, silently creating a 1.7 format
repository is wrong. It's not what the user asked for and it's not
what they will expect to get.
As for your extra step of verifying 'svnadmin version', with or without
a magic compare flag, that's exactly what the admin should do _after_
we return the error message about the version being too new. Then they
can create one with compat level of 1.7. Or figure out why svnadmin
isn't at the version they thought it was.
But Julian's also right that we may as well discard the patchlevel,
since we know the repository format is never sensitive to that.
Peter
Received on 2013-03-22 17:09:46 CET