Re: svn commit: r1459410 - /subversion/trunk/subversion/tests/cmdline/merge_tests.py

Bert Huijben wrote:

>> URL: http://svn.apache.org/r1459410
>> Log:
>> In several tests in merge_tests.py, change directory to the WC first, so
>> the paths printed during the test run are much shorter than they would
>> otherwise be, to ease debugging.
>
> Can we make this optional behavior of the testsuite (or maybe just sbox.build())
> somehow?

I would like to, but have tried before and it's actually very hard.  We store several key paths as relative paths in the test suite framework -- path to where all the tests' working copies should be created, path to where the read-only Greek repository is to be found, etc. -- without being clear what they're relative to.  Some of them are inter-related, and so the simple trick of changing directory to the WC dir and then setting sbox.wc_dir='' only works as long as we don't then try to use certain other functions such as cloning the WC or accessing the pristine Greek repo.  In other words, it's a hack.

> I really like this behavior while debugging, while in general always testing
> with the current directory can introduce other kinds of problems, just like our
> in almost every case the working copy root and repository root are the same
> location during our tests.
> (For some time during 1.7 development the svnversion code only worked correctly
> in this scenario and the test suite didn't notice)

Yup, that's a concern.

- Julian
Received on 2013-03-21 18:55:08 CET