Re: svn commit: r1459058 - in /subversion/trunk/subversion: include/private/svn_dep_compat.h include/private/svn_subr_private.h libsvn_ra_serf/serf.c libsvn_subr/hash.c libsvn_wc/adm_ops.c svn/notify.c svnrdump/dump_editor.c

Julian Foad <julianfoad_at_btopenworld.com> writes:

> Philip Martin wrote:
>
>> I see similar warning for svn_dbg__preamble, svn_dbg__printf,
>> svn_dbg__print_props, svn_error__locate, svn_error__trace when building
>> without -DSVN_DEBUG.
>>
>> The dbg stuff is declared in private/svn_debug.h so I think we could
>> make the dbg definitions conditional as well.
>
> +1 -- sounds sane to me.

r880483 did that but it was reverted in r880505. It seems that on
Windows these have to be defined all the time.

>
>> The error stuff probably needs to always be built since a 3rd party
>> using our headers with -DSVN_DEBUG will generate references to the
>> functions.  We should arrange for the prototype to be visible when
>> compiling error.c
>
> +1.  Move their declarations outside the '#ifdef' blocks that
> currently enclose them, in svn_error.h?

I was thinking of defining SVN_ERR__TRACING in error.c so that the
prototypes are always visible there. I might see if I can do something
similar to make the svn_dbg_ prototypes visible in debug.c.

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download