[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Use svn_hash_gets

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Wed, 20 Mar 2013 13:45:56 +0000 (GMT)

Branko Čibej wrote:

> On 20.03.2013 04:47, Daniel Shahaf wrote:
>> See attached patch.  Any objections to doing that (and similar changes
>> to the rest of the code)?
>
> Must we do this just before branching? I suppose it's a benign change,
> but it /is/ a lot of code churn.

When I tried doing this, I found I had to include <svn_hash.h> in every C file that uses them, which is fairly close to every C file in the project, and that made me think it would be better if we moved the definitions into <svn_types.h> which is our "global" header file.

Personally I don't mind the code churn and, for the purposes of back-porting changes to 1.8.x, there is an advantage to doing it before branching if we're going to do it at all (which I think we are).

- Julian
Received on 2013-03-20 14:46:37 CET

This is an archived mail posted to the Subversion Dev mailing list.