Re: Windows build still requires apr-util?

On 14 March 2013 15:00, Bert Huijben <bert_at_qqmail.nl> wrote:
>
>
>> -----Original Message-----
>> From: Sergei Antonov [mailto:saproj_at_gmail.com]
>> Sent: donderdag 14 maart 2013 14:13
>> To: Bert Huijben
>> Subject: Re: Windows build still requires apr-util?
>>
>> On 14 March 2013 13:44, Bert Huijben <bert_at_qqmail.nl> wrote:
>> >
>> >
>> >> -----Original Message-----
>> >> From: Sergei Antonov [mailto:saproj_at_gmail.com]
>> >> Sent: donderdag 14 maart 2013 13:31
>> >> To: Bert Huijben
>> >> Subject: Re: Windows build still requires apr-util?
>> >>
>> >> On 13 March 2013 19:15, Bert Huijben <bert_at_qqmail.nl> wrote:
>> >> >
>> >> >
>> >> >> -----Original Message-----
>> >> >> From: Sergei Antonov [mailto:saproj_at_gmail.com]
>> >> >> Sent: woensdag 13 maart 2013 18:47
>> >> >> To: dev_at_subversion.apache.org
>> >> >> Subject: Re: Windows build still requires apr-util?
>> >> >>
>> >> >> Gentle reminder: VS 2010 doesn't compile the latest revision.
>> >> >> Please, add "#include <time.h>" into
>> >> >> subversion\libsvn_subr\win32_crashrpt.c and commit.
>> >> >
>> >> > I think that is somehow dependant on other settings as it just compiles
>> for
>> >> me with 2010 (and 2012 and 2008).
>> >>
>> >> Do not compile this file at all?
>> >>
>> >> > Can you explain what makes your environment different
>> >>
>> >> You do not have SVN_USE_WIN32_CRASHHANDLER?
>> >> You use different revision? (mine is 1456399)
>> >>
>> >> Open VS 2010 .sln, navigate to 'win32_crashrpt.c' in project
>> >> 'libsvn_subr', choose Build->Compile. What do you see? I see this:
>> >
>> > I use the crash handler. (Standard settings) and I usually build Subversion
>> trunk multiple times per day with different Visual Studio versions. The file
>> hasn't changed in this respect for years.
>> >
>> > time.h is included by apr.h for me.
>>
>> My apr.h is attached. Can you compare it with yours?
>>
>> > I don't see why we would have to duplicate the include here in my
>> environment.
>>
>> Is time.h from apr.h guaranteed?
>
> Yes

Hard to believe. I don't know about apr specifically, but usually
library headers (like apr.h) are means to deliver library's (i.e.
APR's) functions/types/constants and not means to deliver system
headers. And when they do, it is just a side effect.

> We don't declare apr 2.X support in Subversion, so I would guess that is untested.

Didn't know about not supporting 2.X in subversion. Thanks for
telling. It is not mentioned in 'INSTALL'.

> But I would guess it is still included there.

I used apr 2.0. No time.h there, see the apr.h I sent you.
Received on 2013-03-14 16:02:52 CET