[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] implement keywords substitution in mod_dav_svn

From: Bert Huijben <bert_at_qqmail.nl>
Date: Thu, 7 Mar 2013 17:27:47 +0100

> -----Original Message-----
> From: C. Michael Pilato [mailto:cmpilato_at_collab.net]
> Sent: donderdag 7 maart 2013 17:23
> To: Gavin Baumanis
> Cc: 'jinfroster'; dev_at_subversion.apache.org
> Subject: Re: [PATCH] implement keywords substitution in mod_dav_svn
>
> On 03/07/2013 09:58 AM, Gavin Baumanis wrote:
> > Ping.
> > This thread has received no new comments.
>
> (Thanks, Gavin.)
>
> >> You are right! With this patch SVN client complains on bad checksums...
> >> Sorry, didn't test that well.
> >> But SVN clients do keywords substitution themselves. The idea was to
> >> implement substitution for dumb HTTP clients which are missing it.
> >>
> >> Would it be sufficent to check 'is_svn_client'?
> >>
> >> if (dav_svn__get_keyword_substitution_flag(resource->info->r)
> >> && !resource->info->repos->is_svn_client)
> >> {
> >> ...
> >>
> >> If there are more troubles/questions, please point on them to me.
> >> I'm willing to work on this patch if it has chances to be accepted :)
>
> Yeah, I *think* using the "is_svn_client" flag is acceptable. I can't
> remember now how much weight we attributed to that flag (which is set
> based
> on a grep of the User-Agent string). The downside here is that if there
> happens to be a Subversion client that doesn't report itself as such in this
> way, it will presumably run into the same sorts of issues we've already
> discussed. But I know of no such client, and maybe we as a community are
> willing to say, "Look, if you are to be a well-behaved Subversion client,
> you've gotta slap those four characters "SVN/" in your User-Agent header
> value.

What about proxy servers?

There used to be privacy features in several proxies that suppressed the user agent. (Not sure if they still use that trick).

        Bert
Received on 2013-03-07 17:38:04 CET

This is an archived mail posted to the Subversion Dev mailing list.