[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] correct installation of mod_dontdothat

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 7 Mar 2013 13:40:11 +0200

Julian Foad wrote on Wed, Mar 06, 2013 at 21:32:59 +0000:
> Andreas Stieger wrote:
> > The installation of mod_dontdothat was moved to make install-tools,
> > however the trunk code tries to install with libtool which fails with
> > the message: cannot install mod_dontdothat.la to a directory not ending
> > in [...]/lib/apache2/modules
> >
> > The attached patch fixes this. This was mentioned earlier here:
> > http://mail-archives.apache.org/mod_mbox/subversion-dev/201302.mbox/%3C87ip5yhlrd.fsf@ntlworld.com%3E
> >
> > This can be seen working with an rpm package of the nightly trunk
> > tarballs here:
> > https://build.opensuse.org/package/show?package=subversion&project=home%3AAndreasStieger%3Asvn18
> >
> > [[[
> > * build.conf
> >   (mod_dontdothat): install as apache module
> > ]]]
> With this patch, I confirm that my install (from an out-of-source-tree build) now completes without throwing an error.  It now installs mod_dontdothat during "make install-mods-shared" instead of during "make install-tools".
> However, I don't know if that's what we really want.  If something is under "tools", that suggests to me that it should be installed by "install-tools" and perhaps not by "install-mods-shared"... but we have to do something.  I have no particular objection, as I'm sure package managers can work around it whatever way they wish.

I would suggest 'make install-tools' or 'make install-tools-mod-shared',
and leave 'make install-mods-shared' to subversion/mod_*/.

> What do others think?

The support for apache modules under tools/ is a recent addition. It
wasn't straightforward to add (possibly because the install command for
apache mods differs from that of compiled C binaries?), i.e., "may
contain bugs". IIRC this is also in 1.7 but not all trunk patches were

I'm surprised that Andreas' bug didn't require editing makefile.ezt or

FWIW, it would have been nice to see a diff of build-outputs.mk as

> - Julian
Received on 2013-03-07 12:40:50 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.