[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] correct installation of mod_dontdothat

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Wed, 06 Mar 2013 23:24:50 +0000

Peter Samuelson <peter_at_p12n.org> writes:

>> > That reminds me. We really should be installing Apache modules with
>> > 'libtool --mode=install', because on some platforms that is _not_ just
>> > a simple copy like you'd expect; sometimes it has to do other things.
>
> [Philip Martin]
>> We currently use Apache's apxs to install mod_dav_svn and
>> mod_authz_svn and we leave it up to that script to invoke libtool as
>> required.
>
> Yes, well, how would apxs know anything about libtool? apxs just knows
> there's a module at such-and-such path and it needs to be installed.

On my Debian box apxs knows about libtool.

>> Are you saying we should explictly invoke libtool? Does apxs do the
>> wrong thing?
>
> It certainly does the wrong thing in my Debian build, so I've had to
> patch it to use 'libtool --mode=install' instead / in addition.

On my Debian box apxs does the right thing:

if true ; then cd subversion/mod_authz_svn ; /usr/bin/install -c -d "/usr/local/subversion/apache" ; /usr/bin/apxs2 -i -S LIBEXECDIR="/usr/local/subversion/apache" -n authz_svn mod_authz_svn.la ; fi
/usr/share/apache2/build/instdso.sh SH_LIBTOOL='/usr/share/apr-1.0/build/libtool' mod_authz_svn.la /usr/local/subversion/apache
/usr/share/apr-1.0/build/libtool --mode=install cp mod_authz_svn.la /usr/local/subversion/apache/
libtool: install: warning: relinking `mod_authz_svn.la'
libtool: install: (cd /home/pm/sw/subversion/obj/subversion/mod_authz_svn; /bin/sh /home/pm/sw/subversion/obj/libtool --tag CC --silent --mode=relink gcc -shared -g -O2 -pthread -rpath /usr/local/subversion/apache -avoid-version -module -o mod_authz_svn.la mod_authz_svn.lo ../../subversion/libsvn_repos/libsvn_repos-1.la ../../subversion/libsvn_subr/libsvn_subr-1.la )
libtool: install: cp .libs/mod_authz_svn.soT /usr/local/subversion/apache/mod_authz_svn.so
libtool: install: cp .libs/mod_authz_svn.lai /usr/local/subversion/apache/mod_authz_svn.la
libtool: finish: PATH="/usr/local/subversion/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/sbin" ldconfig -n /usr/local/subversion/apache

Perhaps you mean mod_dontdothat? That doesn't get installed properly
because it doesn't use apxs.

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Received on 2013-03-07 00:25:35 CET

This is an archived mail posted to the Subversion Dev mailing list.