Re: svn commit: r1451129 - in /subversion/branches/fsfs-format7/subversion: include/private/svn_string_private.h libsvn_delta/xdelta.c libsvn_subr/string.c

On Thu, Feb 28, 2013 at 9:39 AM, Bert Huijben <bert_at_qqmail.nl> wrote:

> [retry to the right list]
> If you are not going to use these functions I don’t see how this is going
> to help performance. Before this these functions could be inlined in the
> delta code and now they are part of a different library.
>
> Maybe there is no difference if you are compiling a static library with
> whole program optimization, but with a shared library build there
> certainly will be a performance difference in the delta calculation, which
> is already cpu bound in many real world scenarios.
>
>
As of r1451163 it is being used by other code.

The impact on xdelta is minimal, though. It will only
be called once per a matching sub-string that been
found and adds a mere 10ns or so per call.

-- Stefan^2.

-- 
Certified & Supported Apache Subversion Downloads:
*
http://www.wandisco.com/subversion/download
*