Re: [PATCH] Add '--drop-all-empty-revs' to svndumpfilter include/exclude

On Wednesday 27 February 2013 10:44 PM, Julian Foad wrote:
>
>> + write_out_rev = (! rb->had_dropped_nodes) ? TRUE : FALSE;
>
> No, I don't mean that. "? TRUE : FALSE" is completely redundant, and I want us to avoid that sort of redundancy.
>
> "had_nodes_dropped" is a boolean value -- that is, a yes/no, true/false flag.
>
> "write_out_rev" is a boolean value -- true/false -- as well.
>
> You want "write_out_rev" to be true if "had_dropped_nodes" is false and false if it is true. I'm saying simply use the boolean "not" operator to say "use the opposite truth value", like this:
>
> write_out_rev = ! rb->had_dropped_nodes;
>
> so the statement reads as "write-out-rev = not had dropped nodes", instead of "x ? y : z" which says "if X is true then Y else Z".

Sorry, I misunderstood it. Thanks for your detailed explanation.

Attached the updated patch and log message.

Thanks & Regards,
Vijayaguru