[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1450341 - /subversion/trunk/subversion/libsvn_client/copy.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Tue, 26 Feb 2013 22:06:00 +0000

rhuijben_at_apache.org writes:

> Author: rhuijben
> Date: Tue Feb 26 18:33:04 2013
> New Revision: 1450341
>
> URL: http://svn.apache.org/r1450341
> Log:
> * subversion/libsvn_client/copy.c
> (wc_to_repos_copy): Temporarily revert the introduction of the session pool
> of r1450279 in an attempt to unbreak the javahl tests. Do this by simply
> setting the session pool to the provided scratch pool.

The SEGV happens in testCopy in BasicTests.java, it's the second call to
svn_client_copy6 that fails but if I remove that from the test it still
fails. It appears to be an interaction between Bert's pool change of
r1450279, Stefan's caching change of r1094134 and JavaHL pool
management.

gdb shows:

Program received signal SIGSEGV, Segmentation fault.
0x00007fffea54eb2b in remove_txn_cache (baton_void=0x7ffff0141c80)
    at ../src/subversion/libsvn_fs_fs/caching.c:547
547 if (*baton->to_reset == baton->txn_cache)

(gdb) p baton->txn_cache
$13 = (svn_cache__t *) 0x7ffff0142a28

(gdb) p baton->to_reset
$14 = (svn_cache__t **) 0x7ffff7e27120
(gdb) p baton->to_reset[0]
Cannot access memory at address 0x7ffff7e27120

(gdb) bt
#0 0x00007fffea54eb2b in remove_txn_cache (baton_void=0x7ffff0142c80)
    at ../src/subversion/libsvn_fs_fs/caching.c:547
#1 0x00007fffeb50a957 in ?? () from /usr/lib/libapr-1.so.0
#2 0x00007fffeb5097e9 in apr_pool_destroy () from /usr/lib/libapr-1.so.0
#3 0x00007fffeb5097cc in apr_pool_destroy () from /usr/lib/libapr-1.so.0
#4 0x00007fffeb5097cc in apr_pool_destroy () from /usr/lib/libapr-1.so.0
#5 0x00007fffeb50ad2e in apr_pool_destroy_debug () from /usr/lib/libapr-1.so.0
#6 0x00007ffff08d8617 in svn_client_copy6 (sources=0x7ffff7e360a0,
    dst_path=0x7fffec02e878 "file:///home/pm/sw/subversion/obj/subversion/bindings/javahl/test-work/repositories/basic_test7/parent/A/B", copy_as_child=1,
    make_parents=1, ignore_externals=0, revprop_table=0x0,
    commit_callback=0x7ffff0da8ce0 <CommitCallback::callback(svn_commit_info_t const*, void*, apr_pool_t*)>, commit_baton=0x0, ctx=0x7ffff7e380a0,
    pool=0x7ffff7e36028) at ../src/subversion/libsvn_client/copy.c:2295
#7 0x00007ffff0db8571 in SVNClient::copy (this=0x7fffec01a230,
    copySources=...,
    destPath=0x7fffec06bbc0 "file:///home/pm/sw/subversion/obj/subversion/bindings/javahl/test-work/repositories/basic_test7/parent/A/B",
    message=0x7ffff7fd8bd0, copyAsChild=true, makeParents=true,
    ignoreExternals=false, revprops=..., callback=0x0)
    at ../src/subversion/bindings/javahl/native/SVNClient.cpp:422
#8 0x00007ffff0dc4ad3 in Java_org_apache_subversion_javahl_SVNClient_copy (
    env=0x60a9d0, jthis=0x7ffff7fd8d30, jcopySources=0x7ffff7fd8d28,
    jdestPath=0x7ffff7fd8d20, jcopyAsChild=1 '\001', jmakeParents=1 '\001',
    jignoreExternals=0 '\000', jrevpropTable=0x0, jmessage=0x7ffff7fd8cf8,
    jcallback=0x0)
    at ../src/subversion/bindings/javahl/native/org_apache_subversion_javahl_SVNClient.cpp:529

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Received on 2013-02-26 23:06:53 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.